On Tue, 2022-09-06 at 16:48 +1200, Kieran Frewen wrote: > > + if (ieee80211_is_s1g_beacon(fc)) maybe use "if (ext_hdr)" here so it's easier to understand? Even for static checkers :) > + rx.sta = sta_info_get_bss(prev, ext_hdr->u.s1g_beacon.sa); > + else > + rx.sta = sta_info_get_bss(prev, hdr->addr2); > rx.sdata = prev; > ieee80211_rx_for_interface(&rx, skb, false); > > @@ -4999,6 +5007,10 @@ static void __ieee80211_rx_handle_packet(struct ieee80211_hw *hw, > } > > if (prev) { > + if (ieee80211_is_s1g_beacon(fc)) > + rx.sta = sta_info_get_bss(prev, ext_hdr->u.s1g_beacon.sa); > + else > + rx.sta = sta_info_get_bss(prev, hdr->addr2); > here too, I guess johannes