On Thu, Oct 23, 2008 at 7:23 PM, Luis R. Rodriguez <mcgrof@xxxxxxxxx> wrote: > On Thu, Oct 23, 2008 at 7:45 AM, Johannes Berg > <johannes@xxxxxxxxxxxxxxxx> wrote: >> On Thu, 2008-10-23 at 15:01 +0530, Sujith wrote: >>> Johannes Berg wrote: >>> > It seems that should be a rate control decision? Possibly taking into >>> > account more than just always doing aggregation sessions. Then again, I >>> > suppose aggregation sessions are cheap. What about latency here? >>> > >>> >>> Well, that is what Luis seems to think too, but our RC >>> doesn't do much now, so we try to setup an aggregation session with any >>> associated STA. >> >> If that was done in the RC at least (could easily be moved I suppose) >> and you cleaned up the RC, then surely nbd would play with porting >> minstrel and making it aware of such things, which probably makes for a >> better RC... And since you have to clean up the RC anyway :) > > I checked internally to verify where you would decide when to AMPDU > and to try to get different reviews and opinions, and it seems that > the path we take right now is correct as there is not much overhead so > we always use AMPDU with whoever supports it with data frames. If > you're a STA you do it all the time with the AP for data frames. > > I noticed iwlagn had some more logic within the RC but I gave up > trying to follow the logic. I suspect they do the same though, Tomas? I got different output from our system engineering. APMDU has overhead and if there is not requirement for high throughput we don't initiate one. What is for sure we shounld not have aggregation enabled for VO AC. I've payed attention that there are different APs do that differently some opens BA session on BE AC immediately upon association some do it on high throughput I haven't seen in the second case it will be opened on simple ping. Anyhow if we would implement the triggering on throughput simply setting starting and stopping thresholds to small values will have same effect as your solution and setting it to 0 and maximum will respectively will have effect on opening BA session upon association. Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
