On Wed, Oct 22, 2008 at 10:17:33AM +0200, Johannes Berg wrote: > Good point. We currently don't try again, but we could put this into a > new function and call it from when we need it. Then again, we'll need it > right away, the driver will probably call _get_beacon from > ieee80211_if_config(sdata, IEEE80211_IFCC_BEACON); Yes.. I forgot about that and only looked at probe_resp references inside mlme.c. With that in mind, it probably is cleaner to make ieee80211_sta_join_ibss() fail if it cannot allocate an skb for ProbeResp. If we are going to be doing some cleanup here, I would suggest moving the proberesp building into a helper function and just do skb = ieee80211_sta_build_probe_resp(...); if (!skb) return -ENOMEM; in ieee80211_sta_join_ibss(). -- Jouni Malinen PGP id EFC895FA -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
