On Wed, 2008-10-22 at 11:11 +0300, Jouni Malinen wrote: > On Wed, Oct 22, 2008 at 09:42:37AM +0200, Rami Rosen wrote: > > > Do we want to continue as usual if dev_alloc_skb() in theis method fails? > > I think we should continue and as such, I would rather not see the patch > that proposes to abort here go in. The allocated skb is not used at this > point anyway; it is only used as an optimization to prepare a ProbeRsp > frame for possible future use. This could be done at the time when > ProbeReq is received (and we sent the last Beacon), i.e., only when > needed. Or if the optimization of generating this only once is > considered desirable, that place could try to allocate a new skb if the > one here failed (or do it on first need and cache the result). Good point. We currently don't try again, but we could put this into a new function and call it from when we need it. Then again, we'll need it right away, the driver will probably call _get_beacon from ieee80211_if_config(sdata, IEEE80211_IFCC_BEACON); johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
