On 15.07.22 04:16, Sriram R (QUIC) wrote:
-----Original Message-----
From: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
Sent: Friday, July 1, 2022 3:30 PM
To: Sriram R (QUIC) <quic_srirrama@xxxxxxxxxxx>; nbd@xxxxxxxx
Cc: linux-wireless@xxxxxxxxxxxxxxx
Subject: Re: [PATCH 0/3] Mesh Fast xmit support
WARNING: This email originated from outside of Qualcomm. Please be wary of
any links or attachments, and do not enable macros.
On Fri, 2022-07-01 at 11:59 +0200, Johannes Berg wrote:
> So was skeptical on having a higher cache size(like 250 or 500 max).
> Hence had a value of 50 and left the configuration part for devices
> which needed higher cache.
> But as you mentioned, this is only runtime max memory and not default.
> So we should be fine to set some high limit, If above is not a
> concern could we stick to an upper limit of ~150-200 ?
Right, I'm fine with that. I was just throwing out 500 as a random
number to show that it's not really a huge memory requirement.
But maybe Felix wants to comment? Felix?
Hi Felix,
Could you kindly share your comments on this.
I agree with making it big enough so that almost nobody has to tune it.
I think 512 would be a reasonable default.
By the way, if I'm counting correctly, you might be able to reduce the
size of the cache entries a bit by moving the 'key' field below the
'band' field, getting rid of some padding.
- Felix
