On 7/14/2022 11:45 AM, Johannes Berg wrote:
On Thu, 2022-07-14 at 12:17 +0300, Rustam Subkhankulov wrote:
The assignment of the value to the variable total in the loop
condition must be enclosed in additional parentheses, since otherwise,
in accordance with the precedence of the operators, the conjunction
will be performed first, and only then the assignment.
Due to this error, a warning later in the function after the loop may
not occur in the situation when it should.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Rustam Subkhankulov <subkhankulov@xxxxxxxxx>
Fixes: d3466830c165 ("p54: move under intersil vendor directory")
That fixes can't be right, it just moved the code.
commit 0d4171e2153b70957fe67867420a1a24d5e4cd82
Author: Christian Lamparter <chunkeey@xxxxxxxxxxxxxx>
Date: Wed Feb 16 19:43:06 2011 +0100
p54: implement flush callback
Signed-off-by: Christian Lamparter <chunkeey@xxxxxxxxxxxxxx>
Signed-off-by: John W. Linville <linville@xxxxxxxxxxxxx>
