On Fri, 27 May 2022 09:09:19 +0300, kvalo@xxxxxxxxxx wrote: > >> On Thu, 26 May 2022 20:18:35 +0200, johannes@xxxxxxxxxxxxxxxx wrote: >> >> This, along with the def.h stuff using it, and MODULE_VERSION(), is all >> rather pointless, I think you should remove it. > > s/should/need to/ :) > That is an unexpected comment:) Can you please clarify what is wrong with that place and why it is pointless (regarding the fact that it can be used to keep track of versions of the code, that were upstreamed)? I can see multiple drivers with that macro and related defines. Best regards, Viktor Barna