Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes: > On Tue, 2022-05-24 at 14:33 +0300, viktor.barna@xxxxxxxxxx wrote: >> + >> +config CL8K_VERSION >> + string "Version" >> + depends on CL8K >> + default "8.1.x" >> + help >> + Sets module version, which may be important for FW compatibility >> + analysis and syncing upstream codebase with the internal codebase. >> > > This, along with the def.h stuff using it, and MODULE_VERSION(), is all > rather pointless, I think you should remove it. s/should/need to/ :) -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
