On Tue, 24 May 2022 08:37:50 +0800 Ping-Ke Shih wrote:
> This mistake is existing since initial commit, and I recall the vendor
> driver to find correctness.
>
> Fixes: ee3db469dd31 ("wifi: rtlwifi: remove always-true condition pointed out by GCC 12")
Not fair, I did not break this code. My change did not alter
the functionality.
> Cc: Jakub Kicinski <kuba@xxxxxxxxxx>
> Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
> ---
> This patch should go through net-next tree, because this one is going to fix
> "wifi: rtlwifi: remove always-true condition pointed out by GCC 12" that only
> exits in that tree.
If you want it to go via net-next you must CC netdev@.
But I don't see any reason to rush it, AFAICS the code was added in
2011 - commit 7274a8c22980 ("rtlwifi: rtl8192de: Merge phy routines")
or so. We waited 11 years to notice, we can wait a few weeks for the
patch to propagate thru wireless tree.
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
> index 15e6a6aded319..f6ff32658863d 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
> @@ -2386,7 +2386,10 @@ void rtl92d_phy_reload_iqk_setting(struct ieee80211_hw *hw, u8 channel)
> rtl_dbg(rtlpriv, COMP_SCAN, DBG_LOUD,
> "Just Read IQK Matrix reg for channel:%d....\n",
> channel);
> - _rtl92d_phy_patha_fill_iqk_matrix(hw, true,
> + if ((rtlphy->iqk_matrix[indexforchannel].
> + value[0][0] != 0)
> + /*&&(regea4 != 0) */)
Please don't add the extra brackets around the condition
and the commented out code back in.
> + _rtl92d_phy_patha_fill_iqk_matrix(hw, true,
> rtlphy->iqk_matrix[
> indexforchannel].value, 0,
> (rtlphy->iqk_matrix[
