> -----Original Message----- > From: Jakub Kicinski <kuba@xxxxxxxxxx> > Sent: Monday, May 23, 2022 11:57 PM > To: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > Cc: kvalo@xxxxxxxxxx; johannes@xxxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx; > keescook@xxxxxxxxxxxx; colin.king@xxxxxxxxx > Subject: Re: [PATCH net-next 3/8] wifi: rtlwifi: remove always-true condition pointed out by GCC 12 > > On Mon, 23 May 2022 02:35:32 +0000 Ping-Ke Shih wrote: > > This is a typo since initial commit. Correct it by > > - value[0] != NULL) > > + value[0][0] != 0) > > > > So, NACK this patch. > > Too, late, the patches were already applied, sorry. Please post a fixup. I have sent a patch to correct it: https://lore.kernel.org/linux-wireless/20220524003750.3989-1-pkshih@xxxxxxxxxxx/T/#u Please take it into net-next tree. Thank you Ping-Ke
