On Sun, Oct 19, 2008 at 10:18 PM, Zhu Yi <yi.zhu@xxxxxxxxx> wrote: > On Sun, 2008-10-19 at 20:40 -0700, Luis R. Rodriguez wrote: >> On Sun, Oct 19, 2008 at 7:51 PM, Zhu Yi <yi.zhu@xxxxxxxxx> wrote: >> > On Thu, 2008-10-16 at 04:38 -0700, Luis R. Rodriguez wrote: >> >> So.. you didn't look at the code to check where it may have failed... >> > >> > IIRC, below patch changes the previously allowing none 5GHz channels to >> > allowing all 5GHZ channels. It does resolve our problem. But is it the >> > correct behaviour? Or did I miss anything? >> >> Well if you are using regulatory_hint() and only have rules defined in >> the 2 GHz band then yes it won't ever touch 5 GHz channels... I don't >> like this at all but its what I thought you were asking for. > > No, with this patch the 5GHz reg_rules on the second card are bypassed > by regdomain. Well the code specifically disregards secondary regulatory_hint()'s right now and we reviewed why -- we discussed it at OLS and agreed to go with the first one as that will usually be the built in one. That's why. The restrictive thing to do next to handle more cards better is to keep doing intersections. Regarding doing unions on the regulatory information on bands -- I'm not sure I even like the current patch I posted.. it means for regulatory domains in db.txt which have no 5 GHz band we should be passing at least one small frequency range to indicate to the core no 5 GHz channels are allowed. I'm not liking this... and this is just to handle the case where you cannot provide a regulatory domain for 5 GHz as your EEPROM doesn't have it as your EEPROM is the intersection of the hw capabilities and the regulatory domain so for 2 GHz cards you have no 5 GHz definitions. Again -- how about a static 5 GHz definition for your 2 GHz band cards? This way you can deal with the *rare* case where users plug in a new dual band card and the system had a built in 2 Ghz card. Also -- we do have support for iw reg set, it doesn't seem you have considered the advantages of this as well. Tomas mentioned your 5 GHz case for >= iwlagn cards is pretty easy, how about for iwl3945 and iwl4965? If you have it listed how about putting it in the driver code path for those drivers? How many 5 GHz SKUs are there for these cards? Are there Intel express cards sold BTW? Or we dealing with a case where a box can be sold with a lot of cards pre-installed? Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
