> -----Original Message----- > From: Johannes Berg <johannes@xxxxxxxxxxxxxxxx> > Sent: Tuesday, April 12, 2022 1:47 PM > To: Pkshih <pkshih@xxxxxxxxxxx> > Cc: linux-wireless@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] mac80211: consider Order bit to fill CCMP AAD > > On Tue, 2022-04-12 at 00:37 +0000, Pkshih wrote: > > After I fix my driver, I don't need this, but I think it is worth to > > have > > this patch. > > OK. But I guess that means no hurry. Yes. > > Yeah, thinking about that, I guess you're right. Maybe we can express > the 22 a bit better (some headerlen - 2 with a comment?), but I can look > at that when I apply the patch. How about replacing 22 by 2 + 6 + 6 + 6 + 2 because of "FC | A1 | A2 | A3 | SC | [A4] | [QC]" ? Ping-Ke