On Thu, 2022-03-24 at 08:48 +0800, Ping-Ke Shih wrote: > Follow IEEE 802.11-21 that HTC subfield masked to 0 for all data frames > containing a QoS Control field. > That seems fine, though not sure it's actually _relevant_ - how would we possibly generate such frames in mac80211? > It also defines the AAD length depends on > QC and A4 fields, so change logic to determine length accordingly. This I don't understand. The code > - hdrlen = ieee80211_hdrlen(hdr->frame_control); > - len_a = hdrlen - 2; sets it to the same thing, no? Oh, I see - again you're worried about IEEE80211_HT_CTL_LEN I guess? Maybe just subtract that again? But either way, I'm not sure how we'd generate these in the first place. johannes
