On 12.04.22 11:37, Kalle Valo wrote: > Philippe Schenker <dev@xxxxxxxxxxxx> writes: > >> This reverts commit bf3747ae2e25dda6a9e6c464a717c66118c588c8. >> >> This commit introduces a regression on some systems where the kernel is >> crashing in different locations after a reboot was issued. >> >> This issue was bisected on a Thinkpad P14s Gen2 (AMD) with latest firmware. >> >> Link: https://lore.kernel.org/linux-wireless/5077a953487275837e81bdf1808ded00b9676f9f.camel@xxxxxxxxxxxx/ >> Signed-off-by: Philippe Schenker <dev@xxxxxxxxxxxx> > > Can I take this to wireless tree? Felix, ack? > > I'll also add: > > Fixes: bf3747ae2e25 ("mt76: mt7921: enable aspm by default") Sorry, stupid questions from the regression tracker: wouldn't this cause a regression for users of kernel versions post-bf3747ae2e25, as the power consumption is likely to increase for them? Without having dug into the backstory much: would disabling ASPM for this particular machine using a quirk be the better approach? Or are we assuming a lot of machines are affected? Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) P.S.: As the Linux kernel's regression tracker I'm getting a lot of reports on my table. I can only look briefly into most of them and lack knowledge about most of the areas they concern. I thus unfortunately will sometimes get things wrong or miss something important. I hope that's not the case here; if you think it is, don't hesitate to tell me in a public reply, it's in everyone's interest to set the public record straight.
