Niels Dossche <dossche.niels@xxxxxxxxx> wrote: > cfg80211_ch_switch_notify uses ASSERT_WDEV_LOCK to assert that > net_device->ieee80211_ptr->mtx (which is the same as priv->wdev.mtx) > is held during the function's execution. > mwifiex_dfs_chan_sw_work_queue is one of its callers, which does not > hold that lock, therefore violating the assertion. > Add a lock around the call. > > Disclaimer: > I am currently working on a static analyser to detect missing locks. > This was a reported case. I manually verified the report by looking > at the code, so that I do not send wrong information or patches. > After concluding that this seems to be a true positive, I created > this patch. > However, as I do not in fact have this particular hardware, > I was unable to test it. > > Reviewed-by: Brian Norris <briannorris@xxxxxxxxxxxx> > Signed-off-by: Niels Dossche <dossche.niels@xxxxxxxxx> Patch applied to wireless-next.git, thanks. 3e12968f6d12 mwifiex: add mutex lock for call in mwifiex_dfs_chan_sw_work_queue -- https://patchwork.kernel.org/project/linux-wireless/patch/20220321225515.32113-1-dossche.niels@xxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
