> -----Original Message-----
> From: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
> Sent: Friday, March 11, 2022 4:33 PM
> To: Rameshkumar Sundaram (QUIC) <quic_ramess@xxxxxxxxxxx>
> Cc: linux-wireless@xxxxxxxxxxxxxxx; ath11k@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH 1/2] mac80211: add support to configure 6GHz non-ht
> duplicate transmission
>
> Hi,
>
> Couple of notes below:
>
> > @@ -704,6 +704,7 @@ struct ieee80211_bss_conf {
> > struct cfg80211_he_bss_color he_bss_color;
> > struct ieee80211_fils_discovery fils_discovery;
> > u32 unsol_bcast_probe_resp_interval;
> > + bool he_6g_nonht_dup_beacon_set;
>
> This is missing documentation.
Thanks, will add it in next patch
>
> > + cap = cfg80211_find_ext_elem(WLAN_EID_EXT_HE_OPERATION,
> > + params->tail, params->tail_len);
> > + if (cap && cap->datalen >= sizeof(*he_oper) + 1) {
> > + he_oper = (void *)(cap->data + 1);
> > + he_6ghz_oper = ieee80211_he_6ghz_oper(he_oper);
> > + if (he_6ghz_oper) {
> > + sdata->vif.bss_conf.he_6g_nonht_dup_beacon_set =
> false;
> > + if (u8_get_bits(he_6ghz_oper->control,
> > +
> IEEE80211_HE_6GHZ_OPER_CTRL_DUP_BEACON)) {
> > + sdata-
> >vif.bss_conf.he_6g_nonht_dup_beacon_set = true;
> > + }
>
> no braces needed there, and no u8_get_bits() either, you can just & ?
Sure, I remember I got sparse warnings last time without this (also took reference from net/mac80211/util.c ieee80211_chandef_he_6ghz_oper()), will send v2 with 'just &' anyway.
>
> > + }
> > + }
>
> I am wondering though if this should even be detected from the HE
> operation element itself, rather than from the beacon rate settings that are
> separate in nl80211?
This is a BW dependent bit in HE Oper IE and user space can switch BW (CSA/chan switch scenarios).
Which can call assign_beacon directly, Hence adding the logic here to cover all Beacon change cases.
>
> johannes
