Hi,
Couple of notes below:
> @@ -704,6 +704,7 @@ struct ieee80211_bss_conf {
> struct cfg80211_he_bss_color he_bss_color;
> struct ieee80211_fils_discovery fils_discovery;
> u32 unsol_bcast_probe_resp_interval;
> + bool he_6g_nonht_dup_beacon_set;
This is missing documentation.
> + cap = cfg80211_find_ext_elem(WLAN_EID_EXT_HE_OPERATION,
> + params->tail, params->tail_len);
> + if (cap && cap->datalen >= sizeof(*he_oper) + 1) {
> + he_oper = (void *)(cap->data + 1);
> + he_6ghz_oper = ieee80211_he_6ghz_oper(he_oper);
> + if (he_6ghz_oper) {
> + sdata->vif.bss_conf.he_6g_nonht_dup_beacon_set = false;
> + if (u8_get_bits(he_6ghz_oper->control,
> + IEEE80211_HE_6GHZ_OPER_CTRL_DUP_BEACON)) {
> + sdata->vif.bss_conf.he_6g_nonht_dup_beacon_set = true;
> + }
no braces needed there, and no u8_get_bits() either, you can just & ?
> + }
> + }
I am wondering though if this should even be detected from the HE
operation element itself, rather than from the beacon rate settings that
are separate in nl80211?
johannes
