On 2/4/22 8:13 PM, Johannes Berg wrote:
On Fri, 2022-02-04 at 20:07 +0530, Veerendranath Jakkam wrote:
There are some references for NSS > 8, ex: Table 9-33a, P802.11be_D1.3
hence I used 81.
Right, the spec confuses me. In a lot of places it reserves enough space
for 8 < NSS <= 16, but then it has e.g. Table 36-40 with 4 bits, but
saying "for up to 8 spatial streams" (MU-MIMO). And even for OFDMA it
states in a lot of places that the maximum is only 8.
Please let me know if you would like this to be changed to 51
Nah, don't worry. I think it probably doesn't even really *matter*, we
can safely leave it at 81 anyway (I had evidently miscalculated as 80
before, so I was confused).
We also already had some patches in this area, and I'm just working on a
combination - e.g. in your first patch I don't like the use of FIELD_GET
so much, preferring uXX_get_bits(), but Ilan already had patches here
that deal with that.
For many of the other patches, Ilan and you arrived at a literally bit-
identical version of things!
So I think I'm going to pick a couple of things from him and a couple of
things from you, and send out a combined series. Perhaps later today, if
I manage to get it done.
Sure, Thanks for the update.
Also in your later nl80211 patch I'm thinking we should combine the
HE/EHT GI settings etc., there's no point duplicating all the enums,
though we might want to do some renaming.
Sounds OK?
johannes
Yeah, This looks fine for me.
meanwhile I will upload new patch set with the suggested changes in last
patch.