Search Linux Wireless

Re: [PATCH] brcmfmac: firmware: Fix crash in brcm_alt_fw_path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/27/2022 2:17 PM, Kalle Valo wrote:
Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx> writes:

On 1/27/2022 1:08 PM, Kalle Valo wrote:
Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx> writes:

On 1/19/2022 9:53 AM, Phil Elwell wrote:
On 19/01/2022 06:01, Kalle Valo wrote:
Phil Elwell <phil@xxxxxxxxxxxxxxx> writes:

The call to brcm_alt_fw_path in brcmf_fw_get_firmwares is not protected
by a check to the validity of the fwctx->req->board_type pointer. This
results in a crash in strlcat when, for example, the WLAN chip is found
in a USB dongle.

Prevent the crash by adding the necessary check.

See: https://github.com/raspberrypi/linux/issues/4833

Fixes: 5ff013914c62 ("brcmfmac: firmware: Allow per-board firmware
binaries")
Signed-off-by: Phil Elwell <phil@xxxxxxxxxxxxxxx>

I think this should go to v5.17.

Is that an Ack? Are you asking me to submit the patch in a different way?

Similar/same patch was submitted by Hector Martin [1].

Fine by me. Hector's subset series (fixes) is ready to be taken as
well, right?

I have not looked at Hector's patches yet, my plan is to take them to
wireless-next.

Some of them are improvements so wireless-next is where those belong, but a few (patches #1-3, and #6) are actual bug fixes.

Regards,
Arend

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux