Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx> writes: > On 1/19/2022 9:53 AM, Phil Elwell wrote: >> On 19/01/2022 06:01, Kalle Valo wrote: >>> Phil Elwell <phil@xxxxxxxxxxxxxxx> writes: >>> >>>> The call to brcm_alt_fw_path in brcmf_fw_get_firmwares is not protected >>>> by a check to the validity of the fwctx->req->board_type pointer. This >>>> results in a crash in strlcat when, for example, the WLAN chip is found >>>> in a USB dongle. >>>> >>>> Prevent the crash by adding the necessary check. >>>> >>>> See: https://github.com/raspberrypi/linux/issues/4833 >>>> >>>> Fixes: 5ff013914c62 ("brcmfmac: firmware: Allow per-board firmware >>>> binaries") >>>> Signed-off-by: Phil Elwell <phil@xxxxxxxxxxxxxxx> >>> >>> I think this should go to v5.17. >> >> Is that an Ack? Are you asking me to submit the patch in a different way? > > Similar/same patch was submitted by Hector Martin [1]. > > Regards, > Arend > > [1] > https://patchwork.kernel.org/project/linux-wireless/patch/20220117142919.207370-4-marcan@xxxxxxxxx/ I would prefer to take this patch to wireless tree and drop Hector's version. Is that ok? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
