Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> writes: > Hi Kalle, > > On Wed, Jan 19, 2022 at 7:20 AM Kalle Valo <kvalo@xxxxxxxxxx> wrote: > [...] >> I was about to answer that with a helper function it's easier to catch >> out of bands access, but then noticed the helper doesn't have a check >> for that. Should it have one? > > you mean something like: > if (ac >= IEEE80211_NUM_ACS) > return RTW_TX_QUEUE_BE; > > Possibly also with a WARN_ON/WARN_ON_ONCE Yeah, something like that would be good. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches