On Tue, Dec 14, 2021 at 5:30 PM David Mosberger-Tang <davidm@xxxxxxxxxx> wrote: > > On Tue, 2021-12-14 at 14:04 -0600, Rob Herring wrote: > > On Tue, 14 Dec 2021 16:33:22 +0000, David Mosberger-Tang wrote: > > > Add documentation for the ENABLE and RESET GPIOs that may be needed by > > > wilc1000-spi. > > > > > > Signed-off-by: David Mosberger-Tang <davidm@xxxxxxxxxx> > > > --- > > > .../net/wireless/microchip,wilc1000.yaml | 17 +++++++++++++++++ > > > 1 file changed, 17 insertions(+) > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > Error: Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.example.dts:30.37-38 syntax error > > FATAL ERROR: Unable to parse input tree > > make[1]: *** [scripts/Makefile.lib:373: Documentation/devicetree/bindings/net/wireless/microchip,wilc1000.example.dt.yaml] Error 1 > > make[1]: *** Waiting for unfinished jobs.... > > make: *** [Makefile:1413: dt_binding_check] Error 2 > > So this error appears due to GPIO_ACTIVE_HIGH and GPIO_ACTIVE_LOW in these > lines: > > enable-gpios = <&pioA 5 GPIO_ACTIVE_HIGH>; > reset-gpios = <&pioA 6 GPIO_ACTIVE_LOW>; > > I can replace those with 0 and 1 respectively, but I doubt a lot of people would > recognize what those integers standard for. Is there a better way to get this > to pass? Include the header(s) you use in the example. Rob
