Jouni Malinen <jouni@xxxxxxxxxxxxxx> writes: > From: Baochen Qiang <bqiang@xxxxxxxxxxxxxx> > > The sram dump debugfs interface has to be put under pdev directory > located under /sys/kernel/debug/ath11k/<pdev name>. Currently pdev directory > is created after firmware is ready, this is too late for sram dump. > Suppose that if errors happen and ath11k fails to reach firmware > ready, we have no way to dump sram content to debug cause the > interface has not been created yet. So move it ahead. I'm not sure about this. What will happen with other debugfs files now that they are created before the firmware is ready, doesn't that create race conditions? Also we need to do some refactoring in debugfs, for example see Anil's patch: https://patchwork.kernel.org/project/linux-wireless/patch/1614160542-27882-1-git-send-email-akolli@xxxxxxxxxxxxxx/ So I recommend dropping patch 2 for now and get the basic sram dump functionality ready first. After that we can discuss how to handle firmware crashes during driver initialisation, maybe coredump would be a better approach? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
