Lorenzo Bianconi <lorenzo@xxxxxxxxxx> writes: >> > Lorenzo Bianconi <lorenzo@xxxxxxxxxx> writes: >> > >> > >> Lorenzo Bianconi <lorenzo@xxxxxxxxxx> writes: >> > >> >> > >> >> Lorenzo Bianconi <lorenzo@xxxxxxxxxx> wrote: >> > >> >> >> > >> >> > Fix a possible idr pkt-id leak if the packet is dropped on tx side >> > >> >> > >> > >> >> > Fixes: bd1e3e7b693c ("mt76: introduce packet_id idr") >> > >> >> > Signed-off-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx> >> > >> >> > Acked-by: Felix Fietkau <nbd@xxxxxxxx> >> > >> >> >> > >> >> Patch applied to wireless-drivers.git, thanks. >> > >> >> >> > >> >> 2a9e9857473b mt76: fix possible pktid leak >> > >> > >> > >> > Hi Kalle, >> > >> > >> > >> > Unfortunately I found a regression introduced by this patch >> > >> > for mt7663u (and I >> > >> > guess for mt7921s as well). Do you want me to post a fix or just a v2? >> > >> >> > >> I don't rebase my trees, so please post a fix. I was planning to submit >> > >> a pull request to net tree today, but is this so serious that I should >> > >> skip that? >> > > >> > > I have already tested mt7663u but I do not have mt7921s hw for testing (but the >> > > behaviour should be the same). I guess we can split the patch, just post the >> > > fix for mt7663u and let Sean the time to test it on mt7921s (I am not sure >> > > mt7921s is already available on the market). In this way you can send the PR >> > > today. What do you think? >> > >> > I think it's best to wait, I prefer to have proper build testing on my >> > tree before I submit the pull request. >> >> ack, fine to me. Let's wait for Sean in this case. > > @Sean: if you want to test the code the patch is available here: > https://github.com/LorenzoBianconi/wireless-drivers/commit/1ffda36c7cbe3a6cfc31868895417d0cd6755306 And if we can't find a quick fix let's just revert 2a9e9857473b. I can't wait too long. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches