On Tuesday, 16 November 2021 18:00:58 CET Anilkumar Kolli wrote:
[...]
> @@ -1866,10 +1867,62 @@ static int ath11k_qmi_alloc_target_mem_chunk(struct ath11k_base *ab)
>
> static int ath11k_qmi_assign_target_mem_chunk(struct ath11k_base *ab)
> {
> - int i, idx;
> + struct device *dev = ab->dev;
> + struct device_node *hremote_node = NULL;
> + phandle hremote_phandle;
> + int i, idx, len, sw, aw, host_ddr_sz;
> + u32 *reg, *reg_end;
> + u64 start, size;
>
> for (i = 0, idx = 0; i < ab->qmi.mem_seg_count; i++) {
> switch (ab->qmi.target_mem[i].type) {
> + case HOST_DDR_REGION_TYPE:
> + if (of_property_read_u32(dev->of_node, "memory-region",
> + &hremote_phandle)) {
> + ath11k_dbg(ab, ATH11K_DBG_QMI,
> + "qmi fail to get hremote phandle\n");
> + return 0;
> + }
> +
> + hremote_node = of_find_node_by_phandle(hremote_phandle);
> + if (!hremote_node) {
> + ath11k_dbg(ab, ATH11K_DBG_QMI,
> + "qmi fail to get hremote_node\n");
> + return 0;
> + }
> +
Why aren't you using something like of_address_to_resource? Or some other
__of_get_address related function.
> + aw = of_n_addr_cells(hremote_node);
> + sw = of_n_size_cells(hremote_node);
> +
> + reg = (unsigned int *)of_get_property(hremote_node, "reg", &len);
> + if (!reg) {
> + ath11k_dbg(ab, ATH11K_DBG_QMI,
> + "qmi fail to get reg from hremote\n");
> + return 0;
> + }
> +
> + reg_end = reg + len / (aw * sw);
Why are you multiplying aw with sw? And why are you then dividing len by it?
1. if you calculate (u32 *)x + 1 then then you would increase the address by 4 bytes.
2. for each address + size pair you would have (aw + sw) * 4 bytes
3. len is in bytes
So if you want to get the first byte after a full u32 reg buffer then it would be:
reg + len / sizeof(u32);
If you would want to get the amount of full address+size pairs
len / sizeof(u32) / (aw + sw)
> +
> + do {
> + start = of_read_number(reg, aw);
> + reg += aw;
> + size = of_read_number(reg, sw);
> + reg += sw;
> + } while (reg < reg_end);
What are you trying to achieve with this loop?
Kind regards,
Sven
