On Mon, 2008-10-06 at 18:49 +0200, Tomas Winkler wrote: > On Mon, Oct 6, 2008 at 6:10 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > > This patch cleans up the DMA code to be understandable and not > > completely wrong. In particular: > > * there is no need to have a weird iwl_tfd_frame_data struct that is > > used 10 times, just use an address struct 20 times > > In the hardware this is defined as couples So? That doesn't actually matter at all. > > * therefore, all the is_odd junk goes away > > * fix a bug in iwl_hcmd_queue_reclaim where it would reclaim all the > > fragments of a descriptor rather than all descriptors (this may be > > the cause of the dma unmapping problem I reported) > > * some more cleanups > > > Signed-off-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx> > > -- > > > > Tested on 5000 hw, please apply. > > Great job, however do not apply this before I review it I had strong > feeling this will not > work with aggregation flows. I cannot imagine why you think that, care to explain? johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
