Search Linux Wireless

Re: [PATCH v2] iwlwifi: fix DMA code and bugs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 6, 2008 at 6:10 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:
> This patch cleans up the DMA code to be understandable and not
> completely wrong. In particular:
>  * there is no need to have a weird iwl_tfd_frame_data struct that is
>   used 10 times, just use an address struct 20 times

In the hardware this is defined as couples

>  * therefore, all the is_odd junk goes away
>  * fix a bug in iwl_hcmd_queue_reclaim where it would reclaim all the
>   fragments of a descriptor rather than all descriptors (this may be
>   the cause of the dma unmapping problem I reported)
>  * some more cleanups

> Signed-off-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
> --


> Tested on 5000 hw, please apply.

Great job,  however do not apply this before I review it I had strong
feeling this will not
work with aggregation flows.
Thanks
Tomas
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux