Pkshih <pkshih@xxxxxxxxxxx> writes: >> -----Original Message----- >> From: kvalo=codeaurora.org@xxxxxxxxxxxxxxxxx >> <kvalo=codeaurora.org@xxxxxxxxxxxxxxxxx> On >> Behalf Of Kalle Valo >> Sent: Monday, October 11, 2021 8:07 PM >> To: Pkshih <pkshih@xxxxxxxxxxx> >> Cc: linux-wireless@xxxxxxxxxxxxxxx >> Subject: Re: [PATCH v7 00/24] rtw89: add Realtek 802.11ax driver >> >> Kalle Valo <kvalo@xxxxxxxxxxxxxx> writes: >> >> > Ping-Ke Shih <pkshih@xxxxxxxxxxx> writes: >> > >> >> This driver named rtw89, which is the next generation of rtw88, supports >> >> Realtek 8852AE 802.11ax 2x2 chip whose new features are OFDMA, DBCC, >> >> Spatial reuse, TWT and BSS coloring; now some of them aren't implemented >> >> though. >> >> >> >> The chip architecture is entirely different from the chips supported by >> >> rtw88 like RTL8822CE 802.11ac chip. First of all, register address ranges >> >> are totally redefined, so it's impossible to reuse register definition. To >> >> communicate with firmware, new H2C/C2H format is proposed. In order to have >> >> better utilization, TX DMA flow is changed to two stages DMA. To provide >> >> rich RX status information, additional RX PPDU packets are added. >> >> >> >> Since there are so many differences mentioned above, we decide to propose >> >> a new driver. It has many authors, they are listed in alphabetic order: >> >> >> >> Chin-Yen Lee <timlee@xxxxxxxxxxx> >> >> Ping-Ke Shih <pkshih@xxxxxxxxxxx> >> >> Po Hao Huang <phhuang@xxxxxxxxxxx> >> >> Tzu-En Huang <tehuang@xxxxxxxxxxx> >> >> Vincent Fann <vincent_fann@xxxxxxxxxxx> >> >> Yan-Hsuan Chuang <tony0620emma@xxxxxxxxx> >> >> Zong-Zhe Yang <kevin_yang@xxxxxxxxxxx> >> >> >> >> Tested-by: Brian Norris <briannorris@xxxxxxxxxxxx> >> >> Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> >> >> >> >> v7: >> >> - use consistent license of Kconfig >> >> - remove #ifdef and dummy functions from coex.c >> >> - C2H handler of coex uses meaningful naming insetad, and use le32_to_cpu() >> >> to convert the value. >> >> - add icmp packet notify to coex >> >> - use function call instead of a work to notify coex about traffic changed >> >> - fix dereference security CAM NULL pointer while disconnecting occasionally >> >> - fill tx descriptor once a 32 bits word (Suggested by Arnd. Thanks!) >> >> - use static pci PS, so remove pci link_ps >> >> - make many mac tables constant >> >> - add early_h2c debugfs entry to notify firmware early >> >> - support new RA report format >> >> - configure retry_lowest_rate by band >> >> - avoid to use of whil(1) to parse power sequence >> >> - notify rfk before/after scanning to reset status >> >> - firmware: rtw89: 8852a: update fw to v0.13.30.0 >> >> https://github.com/pkshih/linux-firmware.git >> >> pick the commit 6595133a7cde82be932067afde834dcd036167f8 >> > >> > I have not reviewed this version yet, but I pushed it to the pending >> > branch for build testing: >> > >> > >> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?h= >> pending&id=c321740f93af1a31d9e149ce5077e28bd4e859f7 >> > >> > For the final commit my plan is to squash all patches into one big >> > patch. I will do that after reviewing v7, if everything is ok of course. >> > >> > Are there more Tested-by or Reviewed-by tags? > > Sorry for the late reply. Because our National Day is Oct. 10th, and > additional holiday on Oct. 11th. > > Aaron have tested v5 and a tag is given [1]. > > Tested-by: Aaron Ma <aaron.ma@xxxxxxxxxxxxx> I added Aaron to the commit log and pushed the driver to the master branch: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=e3ec7017f6a20d12ddd9fe23d345ebb7b8c104dd So the driver is now officially accepted, a big thank you to everyone who participated with the review and testing! Now let's see what kind of reports we get from linux-next. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
