On 10/11/21 2:28 AM, Kalle Valo wrote:
Ben Greear <greearb@xxxxxxxxxxxxxxx> writes:
On 8/19/21 9:06 AM, Kalle Valo wrote:
greearb@xxxxxxxxxxxxxxx writes:
From: Ben Greear <greearb@xxxxxxxxxxxxxxx>
This lets user turn on/off this feature. Enabling gives better
tx-rate related stats, but will cause extra driver and (maybe)
firmware work. Not sure if it actually affects performance or
not.
Signed-off-by: Ben Greear <greearb@xxxxxxxxxxxxxxx>
This is grey area, debugfs is not really meant to be used for users
enabling driver features.
What method do you suggest? Surely not trying to drive something down through
netlink for something this chipset specific?
I think a module parameter would be a good choise for enabling this kind
of feature.
Of course the downside of a module parater is that when it's not
possible to configure this per device, only per driver. Like discussed
many times in the past, we would really need some kind more advanced
module parameters which can be per device.
Enabling/disabling via debugfs is way more useful than a module parameter.
It is per-device and also changeable at run-time. Maybe you want to enable
detailed stats for a bit of time for some reason, and then go back to lower
overhead approach.
You are asking for a worse technical solution than debugfs implementation.
For the per-device module parameters, I implemented something similar for
ath10k using a 'fwcfg' file that is loaded with device options sort of like
a board file. That worked well enough for that sort of thing.
Thanks,
Ben
--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc http://www.candelatech.com
