Ben Greear <greearb@xxxxxxxxxxxxxxx> writes: > On 8/19/21 9:06 AM, Kalle Valo wrote: >> greearb@xxxxxxxxxxxxxxx writes: >> >>> From: Ben Greear <greearb@xxxxxxxxxxxxxxx> >>> >>> This lets user turn on/off this feature. Enabling gives better >>> tx-rate related stats, but will cause extra driver and (maybe) >>> firmware work. Not sure if it actually affects performance or >>> not. >>> >>> Signed-off-by: Ben Greear <greearb@xxxxxxxxxxxxxxx> >> >> This is grey area, debugfs is not really meant to be used for users >> enabling driver features. >> > > What method do you suggest? Surely not trying to drive something down through > netlink for something this chipset specific? I think a module parameter would be a good choise for enabling this kind of feature. Of course the downside of a module parater is that when it's not possible to configure this per device, only per driver. Like discussed many times in the past, we would really need some kind more advanced module parameters which can be per device. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
