Search Linux Wireless

Re: [PATCH 4/4] wilc1000: Add support for enabling CRC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ajay,

On Wed, 2021-02-24 at 13:35 +0000, Ajay.Kathat@xxxxxxxxxxxxx wrote:
> 
> One more observation.
> I am not clear if the below block is really needed. Have you faced any
> issue here and did the below logic of skipping data helped to come out
> of it. Also checking the limit of 16384(2*8KB) byte looks odd when the
> max limit for data packet is around 8KB. Am I missing something here.
> 
> > +
> > +                               {
> > +                                       u8 byte;
> > +                                       int i;
> > +
> > +                                       for (i = 0; i < 16384; ++i) {
> > +                                               byte = 0;
> > +                                               wilc_spi_rx(wilc, &byte, 1);
> > +                                               if (!byte)
> > +                                                       break;
> > +                                       }
> > +                               }

Ouch, that's definitely not supposed to be there!  It's left-over debug
code from when I was tracking down the power-save issue.  Not sure how
I missed that.  Thanks for catching it and being so gentle about it! 

How do I fix this best?  Do I resend the entire patch series or is it
OK to create a V2 of just this last patch?


  --david





[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux