On Tue, 12 Jan 2021 16:50:54 +0100, Kalle Valo wrote: > > Takashi Iwai <tiwai@xxxxxxx> writes: > > > The ucode TLV data may be read-only and should be treated as const > > pointers, but currently a few code forcibly cast to the writable > > pointer unnecessarily. This gave developers a wrong impression as if > > it can be modified, resulting in crashing regressions already a couple > > of times. > > > > This patch adds the const prefix to those cast pointers, so that such > > attempt can be caught more easily in future. > > > > Signed-off-by: Takashi Iwai <tiwai@xxxxxxx> > > So this need to go to -next, right? Yes, this isn't urgently needed for 5.11. > Does this depend on patch 1 or can > this be applied independently? It depends on the first patch, otherwise you'll get the warning in the code changing the const data (it must warn -- that's the purpose of this change :) So, if applying to a separate branch is difficult, applying together for 5.11 would be an option. thanks, Takashi
