On Tue, 12 Jan 2021 16:48:56 +0100, Kalle Valo wrote: > > Takashi Iwai <tiwai@xxxxxxx> writes: > > > The commit ba8f6f4ae254 ("iwlwifi: dbg: add dumping special device > > memory") added a termination of name string just to be sure, and this > > seems causing a regression, a GPF triggered at firmware loading. > > Basically we shouldn't modify the firmware data that may be provided > > as read-only. > > > > This patch drops the code that caused the regression and keep the tlv > > data as is. > > > > Fixes: ba8f6f4ae254 ("iwlwifi: dbg: add dumping special device memory") > > BugLink: https://bugzilla.suse.com/show_bug.cgi?id=1180344 > > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=210733 > > Signed-off-by: Takashi Iwai <tiwai@xxxxxxx> > > I'm planning to queue this to v5.11. Should I add cc stable? Yes, it hits 5.10.y. > Luca, can I have your ack? It'd be great if this fix goes in quickly. BTW, I thought network people don't want to have Cc-to-stable in the patch, so I didn't put it by myself. Is this rule still valid? thanks, Takashi