On Sat, Sep 13, 2008 at 12:17:55AM -0400, Pavel Roskin wrote: > On Mon, 2008-09-08 at 11:32 -0700, Jean Tourrilhes wrote: > > > Try the attached patch. > > It's working on x86_64! Thank you! Great, so it's not only me ;-) > The same problem exists in airo and atmel, but they don't use that > argument. Several drivers, including mac80211 use union iwreq_data, > which is fragile. Fortunately, most drivers don't use that argument or > use the "data" field, which is correct. > > The only incorrect use of union iwreq_data is in rndis_wlan. It would > ignore ESSID on x86_64. > > I think the use of union iwreq_data is dangerous and should be avoided. Note, as soon as you are using the data for real, as opposed to only the flags, you would have noticed that something was amiss. So, in essence it should be self correcting. The way I found the cause is that I wanted to dump the ESSID in the driver for debugging purpose. You can't access the ESSID through a iw_param ;-) Note that as you mentionned, the other faulty drivers are not using the arguments, and all drivers using the argument seems to have the right bits. > Regards, > Pavel Roskin Thanks, and have fun... Jean -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
