Search Linux Wireless

Re: [PATCH 01/19] orinoco: Add ESSID specific scanning for Agere fw

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2008-09-08 at 11:32 -0700, Jean Tourrilhes wrote:

> 	Try the attached patch.

It's working on x86_64!  Thank you!

> diff -u -p linux/drivers/net/wireless/orinoco.p1.c linux/drivers/net/wireless/orinoco.c
> --- linux/drivers/net/wireless/orinoco.p1.c	2008-09-08 11:28:01.000000000 -0700
> +++ linux/drivers/net/wireless/orinoco.c	2008-09-08 11:29:59.000000000 -0700
> @@ -3953,7 +3953,7 @@ static int orinoco_ioctl_getrid(struct n
>  /* Trigger a scan (look for other cells in the vicinity */
>  static int orinoco_ioctl_setscan(struct net_device *dev,
>  				 struct iw_request_info *info,
> -				 struct iw_param *srq,
> +				 struct iw_point *srq,
>  				 char *extra)

The same problem exists in airo and atmel, but they don't use that
argument.  Several drivers, including mac80211 use union iwreq_data,
which is fragile.  Fortunately, most drivers don't use that argument or
use the "data" field, which is correct.

The only incorrect use of union iwreq_data is in rndis_wlan.  It would
ignore ESSID on x86_64.

I think the use of union iwreq_data is dangerous and should be avoided.

-- 
Regards,
Pavel Roskin
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux