Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> wrote: > The firmware parameter LINK_FAIL_TX_CNT maps to the prima configuration > file parameter gLinkFailTxCnt and is described as: > > quote: " If within gLinkFailTimeout period(values is mentioned in msec) if > FW doesn't receive acks for gLinkFailTxCnt number of packets, then > link will be disconnected." > > The downstream description sets a minimum value of 1000 a maximum value of > 60000 and a default value of 6000, however it appears that unless we > actually set this value deliberately firmware defaults it to 0. > > Setting this value to non-zero results in the firmware doing link > monitoring. The working example from downstream paradoxically sets the > value to 200, here we opt to set the value to the minimum stipulated in the > configuration file 1000. > > In conjunction with ieee80211_hw_set(wcn->hw, CONNECTION_MONITOR); this > change effects offload of link monitoring to the firmware. > > Tested with: > 'CNSS-PR-2-0-1-2-c1-74-130449-3' wcn3620 > 'CNSS-PR-2-0-1-2-c1-00083' wcn3680 > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> > Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxx> 3 patches applied to ath-next branch of ath.git, thanks. e24eedc09f14 wcn36xx: Set LINK_FAIL_TX_CNT to 1000 on all wcn36xx 8def9ec46a5f wcn36xx: Enable firmware link monitoring 5336fad96e8f wcn36xx: Enable firmware offloaded keepalive -- https://patchwork.kernel.org/project/linux-wireless/patch/20201103121735.291324-2-bryan.odonoghue@xxxxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches