On Wed, Oct 28, 2020 at 9:13 PM Brian Norris <briannorris@xxxxxxxxxxxx> wrote: > > On Wed, Oct 28, 2020 at 2:56 PM Tsuchiya Yuto <kitakar@xxxxxxxxx> wrote: > > > > To make the ps_mode (power_save) control easier, this commit adds a new > > module parameter allow_ps_mode and set it false (disallowed) by default. This sounds like some form of access control, not something that makes power control "easier"? What exactly is the use case. Also, module params in networking devices are discouraged.