On Wed, Oct 28, 2020 at 2:56 PM Tsuchiya Yuto <kitakar@xxxxxxxxx> wrote: > > To make the ps_mode (power_save) control easier, this commit adds a new > module parameter allow_ps_mode and set it false (disallowed) by default. This sounds like a bad idea, as it breaks all the existing users who expect this feature to be allowed. Seems like you should flip the defaults. Without some better justification, NACK. Also, I can't find the other 2 patches in this alleged series. Maybe they're still making it through the mailing lists and archives. Brian > When this parameter is set to false, changing the power_save mode will > be disallowed like the following: > > $ sudo iw dev mlan0 set power_save on > command failed: Operation not permitted (-1) > > Signed-off-by: Tsuchiya Yuto <kitakar@xxxxxxxxx>
