Re: [PATCH] mac80211: save he oper info in bss config for AP and mesh

[Pradeep Kumar Chitrapu <pradeepc@xxxxxxxxxxxxxx>]

> > -u8 *ieee80211_ie_build_he_oper(u8 *pos, struct cfg80211_chan_def 
> > *chandef)
> > +u8 *ieee80211_ie_build_he_oper(u8 *pos, struct cfg80211_chan_def 
> > *chandef,
> > +			       struct ieee80211_sub_if_data *sdata)
> >  {
> >  	struct ieee80211_he_operation *he_oper;
> >  	struct ieee80211_he_6ghz_oper *he_6ghz_op;
> > @@ -3056,6 +3057,7 @@ u8 *ieee80211_ie_build_he_oper(u8 *pos, struct 
> > cfg80211_chan_def *chandef)
> >  	he_oper = (struct ieee80211_he_operation *)pos;
> >  	he_oper->he_oper_params = cpu_to_le32(he_oper_params);
> >
> > +	sdata->vif.bss_conf.he_oper.params = he_oper_params;
>
> I think these changes are inappropriate. This is a helper function to
> build something, not to store the data. Please change the callers
> instead.
>
> johannes
Hi Johannes,

Sorry for late response..

Thanks for the review.. I have tried to address the review comments
provided and created new series @ 
https://patchwork.kernel.org/cover/11824871/

Thanks
Pradeep