Please always capitalize acronyms. I might let you get away with a
lower-case "BSS" since that doesn't actually *mean* anything, but "he"
is actually an English word...
Anyway, since you haven't paid attention to the robot, I'll drop this
one way or the other.
Also,
> -u8 *ieee80211_ie_build_he_oper(u8 *pos, struct cfg80211_chan_def *chandef)
> +u8 *ieee80211_ie_build_he_oper(u8 *pos, struct cfg80211_chan_def *chandef,
> + struct ieee80211_sub_if_data *sdata)
> {
> struct ieee80211_he_operation *he_oper;
> struct ieee80211_he_6ghz_oper *he_6ghz_op;
> @@ -3056,6 +3057,7 @@ u8 *ieee80211_ie_build_he_oper(u8 *pos, struct cfg80211_chan_def *chandef)
> he_oper = (struct ieee80211_he_operation *)pos;
> he_oper->he_oper_params = cpu_to_le32(he_oper_params);
>
> + sdata->vif.bss_conf.he_oper.params = he_oper_params;
I think these changes are inappropriate. This is a helper function to
build something, not to store the data. Please change the callers
instead.
johannes
