Search Linux Wireless

Re: [PATCH 5/3] mac80211: fix typo in action frame handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2008-09-08 at 23:58 +0300, Tomas Winkler wrote:

> It doesn't really matter on which action code you doing the switch.

Oh, I know, but I think it's confusing.

> The full code looks like that
> 
> switch (mgmt->u.action.u.chan_switch.action_code) {
> 		case WLAN_ACTION_SPCT_MSR_REQ:
> 			if (len < (IEEE80211_MIN_ACTION_SIZE +
> 				   sizeof(mgmt->u.action.u.msrment_req)))
> 				break;
> 			ieee80211_sta_process_measurement_req(dev, mgmt);
> 			break;
> 		case WLAN_ACTION_SPCT_CHL_SWITCH:
> 			if (len < (IEEE80211_MIN_ACTION_SIZE +
> 				   sizeof(mgmt->u.action.u.chan_switch)))
> 				break;
> 			ieee80211_sta_process_channel_switch(dev, ifsta,
> 				&mgmt->u.action.u.chan_switch.sw_elem);
> 			break;
> 		case WLAN_ACTION_SPCT_TPC_REQ:
> 			ieee80211_sta_process_tpc_req(dev, mgmt, rx_status);
> 			break;
> 		default:
> 			break;

Does channel switch and measurement have the same category? Can't we
better reflect that in the structure? I thought the union in the struct
had one sub-structure per category.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux