Search Linux Wireless

Re: [PATCH 5/3] mac80211: fix typo in action frame handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 8, 2008 at 5:31 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:
> This says chan_switch.action_code but really means
> measurement.action_code, of course the actual offset in
> the frame is the same, it's just harder to understand
> this way.
>
> Signed-off-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>



>  net/mac80211/mlme.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- everything.orig/net/mac80211/mlme.c 2008-09-08 16:29:54.000000000 +0200
> +++ everything/net/mac80211/mlme.c      2008-09-08 16:29:56.000000000 +0200
> @@ -2997,7 +2997,7 @@ static void ieee80211_rx_mgmt_action(str
>        case WLAN_CATEGORY_SPECTRUM_MGMT:
>                if (local->hw.conf.channel->band != IEEE80211_BAND_5GHZ)
>                        break;
> -               switch (mgmt->u.action.u.chan_switch.action_code) {
> +               switch (mgmt->u.action.u.measurement.action_code) {
>                case WLAN_ACTION_SPCT_MSR_REQ:
>                        if (len < (IEEE80211_MIN_ACTION_SIZE +
>                                   sizeof(mgmt->u.action.u.measurement)))
>
>
It doesn't really matter on which action code you doing the switch.
The full code looks like that

switch (mgmt->u.action.u.chan_switch.action_code) {
		case WLAN_ACTION_SPCT_MSR_REQ:
			if (len < (IEEE80211_MIN_ACTION_SIZE +
				   sizeof(mgmt->u.action.u.msrment_req)))
				break;
			ieee80211_sta_process_measurement_req(dev, mgmt);
			break;
		case WLAN_ACTION_SPCT_CHL_SWITCH:
			if (len < (IEEE80211_MIN_ACTION_SIZE +
				   sizeof(mgmt->u.action.u.chan_switch)))
				break;
			ieee80211_sta_process_channel_switch(dev, ifsta,
				&mgmt->u.action.u.chan_switch.sw_elem);
			break;
		case WLAN_ACTION_SPCT_TPC_REQ:
			ieee80211_sta_process_tpc_req(dev, mgmt, rx_status);
			break;
		default:
			break;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux