Search Linux Wireless

Re: [PATCHv2] ath11k: add raw mode and software crypto support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Venkateswara Naralasetty <vnaralas@xxxxxxxxxxxxxx> writes:

> Adding raw mode tx/rx support. Also, adding support
> for software crypto which depends on raw mode.
>
> To enable raw mode tx/rx:
> insmod ath11k.ko frame_mode=0
>
> To enable software crypto:
> insmod ath11k.ko crypto_mode=1
>
> These modes could be helpful in debugging crypto related issues.
>
> Tested-on: IPQ8074 WLAN.HK.2.1.0.1-01228-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: Manikanta Pubbisetty <mpubbise@xxxxxxxxxxxxxx>
> Signed-off-by: Venkateswara Naralasetty <vnaralas@xxxxxxxxxxxxxx>

[...]

> --- a/drivers/net/wireless/ath/ath11k/wmi.c
> +++ b/drivers/net/wireless/ath/ath11k/wmi.c
> @@ -3366,6 +3366,10 @@ int ath11k_wmi_cmd_init(struct ath11k_base *ab)
>  	config.rx_timeout_pri[2] = TARGET_RX_TIMEOUT_LO_PRI;
>  	config.rx_timeout_pri[3] = TARGET_RX_TIMEOUT_HI_PRI;
>  	config.rx_decap_mode = TARGET_DECAP_MODE_NATIVE_WIFI;
> +
> +	if (test_bit(ATH11K_FLAG_RAW_MODE, &ab->dev_flags))
> +		config.rx_decap_mode = TARGET_DECAP_MODE_RAW;

Did you test this at all? Because to me it looks like in
ath11k_init_wmi_config_ipq8074() this is overwritten with:

	config->rx_decap_mode = TARGET_DECAP_MODE_NATIVE_WIFI;

So I can't see how this would even work. I noticed this while I was
cleaning up ath11k_wmi_cmd_init(). I'll send a patch soon, please test
that and let me know if it works.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux