On Tue, Aug 25, 2020 at 10:49 PM Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> wrote: > > This patch causes a regression betwen Kernel 5.7 and 5.8 at wlcore: > with it applied, WiFi stops working, and the Kernel starts printing > this message every second: > > wlcore: PHY firmware version: Rev 8.2.0.0.242 > wlcore: firmware booted (Rev 8.9.0.0.79) > wlcore: ERROR command execute failure 14 Only if NO firmware for the device in question supports the `KEY_IGTK` value, then this revert is appropriate. Otherwise, it likely isn't. My suspicion is that the feature that `KEY_IGTK` is enabling is specific to a newer firmware that Mauro hasn't upgraded to. What the OP should do is find the updated firmware and give it a try. AND - since there's some firmware the feature doesn't work with, the driver should be fixed to detect the running firmware version and not do things that the firmware doesn't support. AND the firmware writer should also make it so the firmware doesn't barf on bad input and instead rejects it politely. But I will say I'm making an educated guess; while I have played with the TI devices in the past, it was years ago and I won't claim to be an expert. I also am unable to fix it myself at this time. I'd just rather see it fixed properly instead of a knee-jerk reaction of reverting it simply because the OP doesn't have current firmware. And let's revisit the discussion of having a kernel splat because an unrelated piece of code fails yet the driver does exactly what it is supposed to do. We shouldn't be dumping registers and stack-trace when the code that crashed has nothing to do with the registers and stack-trace outputted. It is a false positive. A simple printk WARN or ERROR should output notifying us that the chip firmware has crashed and why. IMHO. - Steve
