Search Linux Wireless

Re: [RFC PATCH 3/3] mac80211: remove disassociation code from ieee80211_set_associated

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2008-09-07 at 01:14 +0300, Tomas Winkler wrote:

> -	ieee80211_led_assoc(local, assoc);
> +	ieee80211_led_assoc(local, 1);
>  
> -	sdata->bss_conf.assoc = assoc;
> +	sdata->bss_conf.assoc = 1;

I think you should use "true" at least for the latter "1"

> +	sdata->bss_conf.assoc = 0;

and "false" here, and if the LED interface uses "bool" then for that
too.

The actual patch looks good to me though.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux