Search Linux Wireless

Re: [RFC PATCH 1/3] mac80211: restructure disassoc/deauth flows

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> +static void ieee80211_set_disassoc(struct ieee80211_sub_if_data *sdata,
> +                                  struct ieee80211_if_sta *ifsta, int deauth,
> +                                  int self_disconnected, u16 reason)

I think you should use bool for those two (deauth, self)

> +	rcu_read_unlock();
> +
> +	sta_info_unlink(&sta);

Those need to be the other way around.


> +       ieee80211_set_associated(sdata, ifsta, 0);

This whole set_associated(0) vs. ieee80211_set_disassoc() business seems
fishy to me, can't we just move the set_associated(0) code into
set_disassoc? AFAICT there's only one caller now that calls with (0),
and that's in set_disassoc().

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux