-----Original Message----- From: linux-wireless-owner@xxxxxxxxxxxxxxx [mailto:linux-wireless-owner@xxxxxxxxxxxxxxx] On Behalf Of Johannes Berg Sent: Friday, September 05, 2008 2:14 PM To: Zhu, Yi Cc: linville@xxxxxxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx; Kolekar, Abhijeet Subject: Re: [PATCH 08/39] iwl3945: replace association and beacon hooks with bss_info_changed cb On Wed, 2008-09-03 at 11:26 +0800, Zhu Yi wrote: > From: Abhijeet Kolekar <abhijeet.kolekar@xxxxxxxxx> > > Let mac80211 and bss_info_changed callback handle the association and > beacon changes. Nice. > @@ -688,87 +688,6 @@ static void iwl3945_rx_reply_rx(struct iwl3945_priv *priv, > > switch (le16_to_cpu(header->frame_control) & IEEE80211_FCTL_FTYPE) { > case IEEE80211_FTYPE_MGMT: You can, umm, simplify all this code a bit now: --------- Patch is on way :-) Thanks Abhijeet --------- if (priv->iw_mode == IEEE80211_IF_TYPE_MNTR) { iwl3945_pass_packet_to_mac80211(priv, rxb, &rx_status); return; } switch (le16_to_cpu(header->frame_control) & IEEE80211_FCTL_FTYPE) { case IEEE80211_FTYPE_MGMT: case IEEE80211_FTYPE_DATA: /* fall through */ default: iwl3945_pass_packet_to_mac80211(priv, rxb, &rx_status); break; } a single line can express the same :) johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
