On Wed, 2008-09-03 at 11:26 +0800, Zhu Yi wrote:
> From: Abhijeet Kolekar <abhijeet.kolekar@xxxxxxxxx>
>
> Let mac80211 and bss_info_changed callback handle the association and
> beacon changes.
Nice.
> @@ -688,87 +688,6 @@ static void iwl3945_rx_reply_rx(struct iwl3945_priv *priv,
>
> switch (le16_to_cpu(header->frame_control) & IEEE80211_FCTL_FTYPE) {
> case IEEE80211_FTYPE_MGMT:
You can, umm, simplify all this code a bit now:
if (priv->iw_mode == IEEE80211_IF_TYPE_MNTR) {
iwl3945_pass_packet_to_mac80211(priv, rxb, &rx_status);
return;
}
switch (le16_to_cpu(header->frame_control) & IEEE80211_FCTL_FTYPE) {
case IEEE80211_FTYPE_MGMT:
case IEEE80211_FTYPE_DATA:
/* fall through */
default:
iwl3945_pass_packet_to_mac80211(priv, rxb, &rx_status);
break;
}
a single line can express the same :)
johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
