> On Jun 16, 2020, at 19:07, Tony Chuang <yhchuang@xxxxxxxxxxx> wrote:
>
>> On 6/3/20 4:42 AM, yhchuang@xxxxxxxxxxx wrote:
>>> From: Tzu-En Huang <tehuang@xxxxxxxxxxx>
>>>
>>> Since 8821C code is ready, we can build it.
>>>
>>> Signed-off-by: Tzu-En Huang <tehuang@xxxxxxxxxxx>
>>> Signed-off-by: Yan-Hsuan Chuang <yhchuang@xxxxxxxxxxx>
>>
>> I added this code to the rtw88 GitHub repository that I maintain. I do not have
>> an 8821CE card and have no way to test it; however, there is at least one user.
>>
>> That user has built the driver and gets the firmware loaded, but runs into the
>> following:
>>
>> [ 12.378158] rtw_8821ce 0000:02:00.0: Firmware version 24.5.0, H2C
>> version 12
>> [ 12.404834] rtw_8821ce 0000:02:00.0: rfe 2 isn't supported
>> [ 12.404937] rtw_8821ce 0000:02:00.0: failed to setup chip efuse info
>> [ 12.404939] rtw_8821ce 0000:02:00.0: failed to setup chip information
>>
>
> I need to check the devices with RFE type 2. I am not sure if they are supported.
> But you can try to add RFE 2 in rtw8821c.c, that can probably work.
I added RFE2 to the rfe_defs table:
diff --git a/drivers/net/wireless/realtek/rtw88/rtw8821c.c b/drivers/net/wireless/realtek/rtw88/rtw8821c.c
index c41c61ee2fb6..73f3b9f1ae31 100644
--- a/drivers/net/wireless/realtek/rtw88/rtw8821c.c
+++ b/drivers/net/wireless/realtek/rtw88/rtw8821c.c
@@ -1219,6 +1219,7 @@ static const struct rtw_intf_phy_para_table phy_para_table_8821c = {
static const struct rtw_rfe_def rtw8821c_rfe_defs[] = {
[0] = RTW_DEF_RFE(8821c, 0, 0),
+ [2] = RTW_DEF_RFE(8821c, 0, 0),
};
static struct rtw_hw_reg rtw8821c_dig[] = {
However, the driver triggers a NULL pointer dereference, because there are many rfe ops are missing for 8821c.
Kai-Heng
>
> Yen-Hsuan
