On Wed, Sep 3, 2008 at 4:59 PM, Marcel Holtmann <holtmann@xxxxxxxxxxxxxxx> wrote: > Hi Tomas, > >> >> > This patch fixes a critical bug that only the last calibration result >> >> > was applied. On reception of one calibration result all the calibration >> >> > results were freed therefore only last was applied. The patch fixes this >> >> > problem by introducing a generic init calibration framework which allows >> >> > variable number of init calibrations and allows addition new HW. >> >> > >> >> > Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx> >> >> > Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@xxxxxxxxx> >> >> > Signed-off-by: Zhu Yi <yi.zhu@xxxxxxxxx> >> >> >> >> This is borderline, I would rather hold off on such a sizable change >> >> for 2.6.27 as I'll have a hard time justifying it. >> > >> > do you see any way for fixing (or improving) this with the current code >> > and hold the whole framework change off until the next merge window. >> > >> > Maybe instead of iwl_free_calib_results(priv); just freeing them >> > individually in their case statements. >> > You know the hardware better than I do, but that should just work >> > (judging from the code). >> >> In general it's possible, but we've already tested this fix. Because >> this is sensitive, even if the code looks okay I cannot approve it >> until we run the whole validation cycle and measurements in the lab so >> it will take some time. Last time we broke it code also looked good :) > > if I understood Dave correctly, then we either come up with a temporary > fix that is small and simple (even if it is not a long term solution) or > no fix for this issue is going into 2.6.27 at all. The fix that I have > in mind removes one line and adds 6 new ones. > > And of course it needs to be tested, but that should be true for > everything that goes into the kernel. I can write the temporary patch > for it, but you guys are the experts with this hardware. So I leave it > up to you. Writing the fix is not the problem, just to get the cycles from the testing. Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
